docs(hoppscotch): sync template standards updates#353
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR adds a Network Policy section to the Hoppscotch playground config, registers Hoppscotch in the playground mapping, and updates the Hoppscotch chart docs with a newer image tag plus additional documented parameters. ChangesHoppscotch Network Policy playground and docs
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
Synced this site PR with the Hoppscotch chart change in helmforgedev/charts#675. What changed:
Validation:
|
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - Keep the Helm test hook under `templates/tests/connection-test.yaml` so `helm test` renders and executes it, with unittest coverage for the hook pod. - Add `networkPolicy.extraEgress` while preserving legacy `networkPolicy.egress`. - Add `extraManifests` and unit coverage for additional rendered manifests. - Make dual-stack, external-db, and external-secrets CI scenarios self-contained for local k3d. - Add network policy unit coverage for baseline, extra egress, and legacy egress compatibility. ## Related - Site sync: helmforgedev/site#353. - Closes #633. ## Validation - `helm template test charts/hoppscotch | rg -n "helm.sh/hook|test-connection|connection-test"` (hook rendered from `templates/tests/connection-test.yaml`) - `helm unittest charts/hoppscotch` (81 tests, 14 suites) - `make template-standards-check CHART=hoppscotch` - `node scripts/charts/validate-chart.js --chart hoppscotch --no-k3d` - `make validate-chart CHART=hoppscotch TIMEOUT=900` (FULLY VALIDATED, 18 layers) - `make site-sync-check CHART=hoppscotch` - `make release-check REPO=charts` - `make attribution-check REPO=charts` ## Site Validation - `npm run lint` - `npm run format:check` - `npm run build` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added `extraManifests` to render additional Kubernetes resources during the Helm release (with templating support). * Added optional `networkPolicy.extraEgress` to append extra egress rules to generated NetworkPolicies. * **Bug Fixes** * Updated CI chart setup to use an in-cluster PostgreSQL service and updated external-secrets sourcing for CI runs. * Adjusted dual-stack service behavior to prefer dual-stack addressing. * **Tests** * Added/updated Helm tests covering extra manifests rendering and NetworkPolicy egress ordering/appending. * **Documentation** * Updated chart docs and `values.schema.json` for `extraManifests` and `extraEgress`. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
99dcbdb to
e8ad4d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Chart PR: helmforgedev/charts#675
Summary by CodeRabbit
New Features
Documentation
2026.5.0.networkPolicy.extraEgressandextraManifests.